Replace InterfaceType with FacetType
#4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value" This reverts commit 39bf354.
geoffromer
reviewed
Nov 8, 2024
| @@ -8,19 +8,39 @@ | |||
| // TIP: To dump output, run: | |||
| // TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/impl/fail_impl_bad_interface.carbon | |||
|
|
|||
| // CHECK:STDERR: fail_impl_bad_interface.carbon:[[@LINE+10]]:1: error: semantics TODO: `impl as non-interface` [SemanticsTodo] | |||
There was a problem hiding this comment.
FWIW, losing this diagnostic seems like a regression to me, since it's the clearest explanation of what's wrong with this code, but we can presumably circle back to that later.
There was a problem hiding this comment.
The diagnostic was not particularly targeted before. It would print this anytime there was any error in the expression after the as.
Co-authored-by: Geoff Romer <[email protected]>
Co-authored-by: Geoff Romer <[email protected]>
geoffromer
approved these changes
Nov 11, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
This was broken by #4499 . --------- Co-authored-by: Josh L <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few things:
TypeIdin theFacetTypeInfostruct with a vector ofInterfaceId,SpecificIdpairs (sorted in id order) representing the set of interface requirements of the facet type. This will later be used to support facet types with multiple interface requirements (as inI & JorI where .Self impls J).InterfaceTypeinstructions (used as the type of anInterfaceDeclinstruction) withFacetTypeinstructions (introduced in Add facet type values and an instruction that produces them #4460) with a (newly introduced)FacetTypeFromInterface()function.InterfaceTypevalues with code that consumedFaceTypevalues. I've generally left the assumption in the code that it is dealing with a single interface, using the (newly introduced)FacetTypeInfo::TryAsSingleInterface, and producing an error otherwise. There isn't yet support for the&operator orwhere .Self impls, so this is generally a good assumption for now, except you can get a facet type with no associated interfaces from atype where... expression. In some cases, the facet type value is pulled from the evaluation of anInterfaceDeclinstruction, where the single interface assumption will hold permanently.There is still a lot left to do, including:
typeshould be a facet type with a reserved id, replacing the built-in instruction.TryAsSingleInterfaceshould generally be upgraded to handle more than (or less than) one interface. Name lookup should be particularly exciting.&should be defined on facet types, unioning their interface and other requirements.whereclause don't do anything yet.