Don't create instructions for implicit constants. #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an instruction is created as part of an implicit call to an interface member, we generated a bunch of constants for naming the interface, finding the corresponding specific, accessing its member function, and so on. This led to significant bloat in SemIR. Instead, we now track whether an instruction is created implicitly in its location, and where relevant, we use the constant value of the instruction directly instead of storing a new `Inst`. This doesn't reduce the amount of work we need to do, but does make the representation in SemIR smaller and more readable.
|
I'm not entirely sure whether this is a good direction, but it seems like it should be easy to back out if we decide we don't like it. |
josh11b
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an instruction is created as part of an implicit call to an
interface member, we generated a bunch of constants for naming the
interface, finding the corresponding specific, accessing its member
function, and so on. This led to significant bloat in SemIR.
Instead, we now track whether an instruction is created implicitly in
its location, and where relevant, we use the constant value of the
instruction directly instead of storing a new
Inst.This doesn't reduce the amount of work we need to do, but does make the
representation in SemIR smaller and more readable.