Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo in p0144 Numeric literal semantics #4478

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

danakj
Copy link
Contributor

@danakj danakj commented Nov 4, 2024

This was already corrected in the design at
https://github.com/carbon-language/carbon-lang/blob/trunk/docs/design/expressions/literals.md#implicit-conversions

The text means to say "rejected" but says "represented".

@danakj
Copy link
Contributor Author

danakj commented Nov 4, 2024

operations as `Int(n)`. `Rational(T)` supports the same operations as
`Float(n)`.

I was wondering these meant to say IntLiteral() and FloatLiteral() as well?

Edit: Answering my own question. The design for Defined Types says the same and provides a link. It means the Int(N)/Float(N) builtin types which have aliases like i32 etc, as in runtime values instead of literals.

@danakj
Copy link
Contributor Author

danakj commented Nov 4, 2024

Thanks, could you also approve the workflows, they seem to be separate?

@zygoloid zygoloid added this pull request to the merge queue Nov 4, 2024
Merged via the queue into carbon-language:trunk with commit fcd6114 Nov 4, 2024
8 checks passed
@danakj danakj deleted the patch-1 branch November 4, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants