Refactor subcommand addition for sharing. #4474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerc
approved these changes
Nov 2, 2024
toolchain/driver/driver_subcommand.h
Outdated
Comment on lines
31
to
33
| // Adds the subcommand to the main command, assigning `selected_command` when | ||
| // the subcommand is in use. | ||
| auto AddSubcommand(CommandLine::CommandBuilder& b, |
There was a problem hiding this comment.
Calling this method AddSubcommand ends up a bit confusing for me because the relationship between this and b are reversed here vs. the analogous method on b.
Maybe a slightly different name would make the relationship more clear?
RegisterWith or AddTo?
Happy for that to be in this PR or a follow-up if that's easier for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to standardize the setup a little more.