Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor run_tool #4459

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Refactor run_tool #4459

merged 1 commit into from
Oct 30, 2024

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Oct 30, 2024

Removes the python script, should get equivalent results in the current setup.

@github-actions github-actions bot requested a review from josh11b October 30, 2024 22:25
@chandlerc chandlerc requested review from chandlerc and removed request for josh11b October 30, 2024 22:33
chandlerc
chandlerc approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooo, nice! Didn't realize how easy that would be in starlark! LG

@jonmeow jonmeow added this pull request to the merge queue Oct 30, 2024
Merged via the queue into carbon-language:trunk with commit fe23a4f Oct 30, 2024
10 checks passed
@jonmeow jonmeow deleted the run-carbon branch October 30, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerc chandlerc chandlerc approved these changes

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonmeow @chandlerc