Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dict.update call with explicit dict #4455

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Replace dict.update call with explicit dict #4455

merged 1 commit into from
Oct 30, 2024

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Oct 30, 2024

https://bazel.build/rules/lib/core/dict#update indicates it returns None. Maybe this hasn't worked for a long time, and was missed due to the issue fixed by #4363

@zygoloid zygoloid added this pull request to the merge queue Oct 30, 2024
Merged via the queue into carbon-language:trunk with commit 69d1d34 Oct 30, 2024
10 checks passed
@jonmeow jonmeow deleted the dict-update branch October 30, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid zygoloid approved these changes

Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonmeow @zygoloid