Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elide prelude components in the IR formatter. #4453

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Oct 29, 2024

This is in particular to avoid churn from changes such as #4370. I think the import list can be helpful (particularly to understand what the library is aware of), but it's a different trade-off for the prelude package due to the implicit imports.

Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, especially for tests where the prelude is so noisy.

I wonder if we may want this to work the other way by default outside of file tests, but no reason to worry about that today. LG.

toolchain/sem_ir/formatter.cpp Show resolved Hide resolved
@jonmeow jonmeow added this pull request to the merge queue Oct 30, 2024
Merged via the queue into carbon-language:trunk with commit d944347 Oct 30, 2024
10 checks passed
@jonmeow jonmeow deleted the elide-prelude-components branch October 30, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants