Add support for deduction of most kinds of type constant. #4389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #4380. |
jonmeow
approved these changes
Oct 8, 2024
Comment on lines
+335
to
+338
| worklist_.AddInstArg(kind0, param_inst.arg0(), arg_inst.arg0(), | ||
| needs_substitution); | ||
| worklist_.AddInstArg(kind1, param_inst.arg1(), arg_inst.arg1(), | ||
| needs_substitution); |
There was a problem hiding this comment.
Is it worth at all conditioning this based on the # of args to the inst? Or if the arg is invalid?
There was a problem hiding this comment.
We could have different case blocks for different numbers of arguments, but I think it's probably not worth the complexity and tighter coupling. The switch in AddInstArg immediately catches the case of no corresponding argument, so we should deal with that case quickly.
So far, we don't have any cases where the arg can be present but invalid. I guess we can handle that if/when it starts coming up.
This adds deduction in all the cases where we can match the instruction fields of the parameter against the corresponding instruction fields of the argument. This handles all current type constants except for struct types, for which we would want to match by field name.
Co-authored-by: Jon Ross-Perkins <[email protected]>
zygoloid
force-pushed
the
toolchain-deduce-more
branch
from
7d9e939
to
e82a0aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds deduction in all the cases where we can match the instruction
fields of the parameter against the corresponding instruction fields of
the argument. This handles all current type constants except for struct
types, for which we would want to match by field name.