Add skeletal format subcommand. #4383
Conversation
| return result; | ||
| } | ||
|
|
||
| auto per_file_error = [&]() { |
There was a problem hiding this comment.
Maybe:
| auto per_file_error = [&]() { | |
| auto mark_per_file_error = [&]() { |
| result.per_file_success.push_back({f.str(), true}); | ||
|
|
||
| // TODO: Consider refactoring this for sharing with compile. | ||
| auto source = SourceBuffer::MakeFromFileOrStdin(driver_env.fs, f, consumer); |
There was a problem hiding this comment.
Does it make sense to check for - here when there are multiple inputs? Or does the driver environment already handle that?
There was a problem hiding this comment.
(or a TODO, I understand this is just a framework)
There was a problem hiding this comment.
Added a TODO. I grant the behavior for the user if they specify - multiple times may be odd (content in the first, empty for later, I'm expecting).
I think the driver environment doesn't handle this. Maybe it should, given that compile would have that issue too? Might mean factoring out this function wasn't worthwhile on the whole.
| // Options for the format subcommand. | ||
| // | ||
| // See the implementation of `Build` for documentation on members. |
There was a problem hiding this comment.
Maybe a TODO here or on the Build command for adding line-range flags and formatting support?
There was a problem hiding this comment.
I'm putting this on the Format call... later PRs are putting a few TODOs there already, so it seems like a good central spot to find missing features.
This extracts out the SourceBuffer handling of
-in order to trivially share it.Note this still has a number of TODOs, it's just setting up the essential subcommand infrastructure, with some tests demonstrating that it at least does something.