Add statement syntax for function declarations #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffromer
reviewed
Apr 8, 2021
Co-authored-by: Geoff Romer <[email protected]>
…n-lang into proposal-functions
jonmeow
commented
Apr 8, 2021
There was a problem hiding this comment.
Thanks for the comments. Just to be sure, if you think I'm pushing too far on forward declarations, please let me know -- it'd just come into my mind as I figured it was something I should cover, particularly as I was gathering examples and Carbon will be a bit of an exception for still having forward declarations.
jonmeow
added
proposal rfc
josh11b
reviewed
Apr 15, 2021
jonmeow
commented
Apr 19, 2021
|
Updated to reflect the conclusion of #463 |
josh11b
reviewed
May 18, 2021
Co-authored-by: josh11b <[email protected]>
zygoloid
approved these changes
May 19, 2021
github-actions
bot
added
proposal accepted
jonmeow
added a commit
that referenced
this pull request
Jan 28, 2022
I was doing this for #851 initially, but I think #438 and #826 hadn't made it in (possibly intentionally due to #851? I don't recall). Co-authored-by: Chandler Carruth <[email protected]> Co-authored-by: Richard Smith <[email protected]>
chandlerc
pushed a commit
that referenced
this pull request
Jun 28, 2022
Add statement syntax (either `fn` or `func`, see proposal) for function declarations. - Follows C++-style trailing return syntax. Co-authored-by: Geoff Romer <[email protected]> Co-authored-by: josh11b <[email protected]>
chandlerc
added a commit
that referenced
this pull request
Jun 28, 2022
I was doing this for #851 initially, but I think #438 and #826 hadn't made it in (possibly intentionally due to #851? I don't recall). Co-authored-by: Chandler Carruth <[email protected]> Co-authored-by: Richard Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add statement syntax (either
fnorfunc, see proposal) for function declarations.