Some trivial check-phase inlining. #4362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When profiling, these jumped out as good inline candidates that happened to be out-of-line, this just moves them inline so that they're available. I think as much as 10% improvement in check-phase from this, but I haven't run detailed before/after measurements as these changes seemed minimally disruptive.
zygoloid
approved these changes
Oct 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profiling, these jumped out as good inline candidates that happened to be out-of-line, this just moves them inline so that they're available. I think as much as 10% improvement in check-phase from this, but I haven't run detailed before/after measurements as these changes seemed minimally disruptive.
Also switched from
CHECKtoDCHECKin one place that seems especially hot and where the check itself seems reasonable to only do in debug builds. Left a comment since we rarely need to remove these any more.