Support initialization of specific classes from struct literals #4320
Conversation
initialization.
representation for a class type.
|
Most of the test changes are caused by the change in representation. For the functionality changes, see |
| const auto& class_info = context.classes().Get(class_id); | ||
| if (class_info.base_id.is_valid()) { | ||
| CARBON_DIAGNOSTIC(AdaptWithBase, Error, | ||
| "Adapter cannot have a base class."); |
There was a problem hiding this comment.
Getting to the diagnostic phrasing discussion, should this be "Adapter has a base class"?
Note I don't have a strong opinion, just asking to try to get a similar voice as we add diagnostics.
Oh, but more seriously... you can probably remove the capital and period now. The related PR is still pending but I think it'd make sense to stop writing those into new diagnostics.
| if (class_info.base_id.is_valid()) { | ||
| CARBON_DIAGNOSTIC(AdaptWithBase, Error, | ||
| "Adapter cannot have a base class."); | ||
| CARBON_DIAGNOSTIC(AdaptBaseHere, Note, "`base` declaration is here."); |
There was a problem hiding this comment.
FWIW with this and AdaptFieldsHere, had you considered "AdaptWithBaseHere", using the main error as a prefix to tie the note more closely together? (or, AdaptBase/AdaptFields, dropping "With")
|
Per in-person discussion: the diagnostic stuff here was just moved to a different function, not added or renamed, so I'm going to leave those comments for a separate PR. |
Doing this to a couple of diagnostics was suggested in review comments on #4320, so I've applied the suggestions across the whole file. --------- Co-authored-by: Jon Ross-Perkins <[email protected]>
Add support for initializing types like
GenericClass(i32)from a struct literal. A new kind of instruction,complete_type_witness, is added to the class definition to track the object representation type so that it's visible to the generics machinery. Accesses to the object representation of a class have all been updated to pass in the class'sSpecificIdso that the types of the fields of the specific class are used instead of the types of the fields of the generic class in places that look at the object representation -- primarily class initialization.