Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parse support for multiple requirements after where separated by and #4298

Merged
merged 99 commits into from
Sep 11, 2024

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Sep 11, 2024

Follow on to #4275 that added where parse support.

…dle the rewrite special form in the future
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; feel free to merge with the suggested changes applied.

toolchain/parse/handle_requirement.cpp Outdated Show resolved Hide resolved
toolchain/parse/state.def Outdated Show resolved Hide resolved
@@ -219,6 +219,8 @@ class TokenizedBuffer : public Printable<TokenizedBuffer> {

auto size() const -> int { return token_infos_.size(); }

// This is an upper bound on the number of output parse nodes in the absence
// of errors.
auto expected_parse_tree_size() const -> int {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be clearer to rename this to expected_max_parse_tree_size or similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@josh11b josh11b removed the request for review from chandlerc September 11, 2024 20:53
@josh11b josh11b added this pull request to the merge queue Sep 11, 2024
Merged via the queue into carbon-language:trunk with commit d6b2fb1 Sep 11, 2024
8 checks passed
@josh11b josh11b deleted the and branch September 11, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants