-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parse support for multiple requirements after where
separated by and
#4298
Conversation
Co-authored-by: Richard Smith <[email protected]>
… of a helper function
…dle the rewrite special form in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; feel free to merge with the suggested changes applied.
toolchain/lex/tokenized_buffer.h
Outdated
@@ -219,6 +219,8 @@ class TokenizedBuffer : public Printable<TokenizedBuffer> { | |||
|
|||
auto size() const -> int { return token_infos_.size(); } | |||
|
|||
// This is an upper bound on the number of output parse nodes in the absence | |||
// of errors. | |||
auto expected_parse_tree_size() const -> int { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be clearer to rename this to expected_max_parse_tree_size
or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Co-authored-by: Richard Smith <[email protected]>
Follow on to #4275 that added
where
parse support.