Refactor InstBlockStack to use ArrayStack. #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #4103 |
chandlerc
approved these changes
Jul 3, 2024
common/array_stack.h
Outdated
| @@ -47,6 +47,16 @@ class ArrayStack { | |||
| return llvm::ArrayRef(elements_).slice(array_offsets_.back()); | |||
| } | |||
|
|
|||
| // Returns the array at a specific index. | |||
| auto PeekArrayAt(int index) const -> llvm::ArrayRef<ValueT> { | |||
| CARBON_CHECK(index < static_cast<int>(array_offsets_.size())); | |||
There was a problem hiding this comment.
llvm::ArrayRef has an equivalent assert, do we need it here as well?
|
Also added some tests for ArrayStack functions while I was in there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of ArrayStack here is intended to simplify the logic, and also make better use of the inst heap allocations. Prior changes #4101 and #4103 removed the less related logic from InstBlockStack, although #4103 is the actual part that blocked using ArrayStack.
BTW, note the PrintForStackDump implementation was incorrect because it didn't apply size_. This simplification fixes the issue.