Add GenericInstance type to represent instances of generics.
#4085
Conversation
canonicalization to have already been done.
toolchain/sem_ir/generic.h
Outdated
|
|
||
| // Context for hashing keys. | ||
| struct KeyContext { | ||
| llvm::ArrayRef<GenericInstance> instances; |
There was a problem hiding this comment.
Should this be private? It doesn't seem like it's part of the public API, so it strikes me as odd to put it first. hashtable_key_context.h's example provides the interface as a class, so would similar work here?
There was a problem hiding this comment.
This is just a struct; given the limited scope I don't think it makes sense to add encapsulation here.
There was a problem hiding this comment.
That said... looking at this again, I don't think this needs to be in the header file. Moved to the .cpp file. Maybe that provides the level of privateness you're looking for?
toolchain/sem_ir/generic.h
Outdated
| // entity, this contains the corresponding non-generic value. This includes | ||
| // values for the compile-time parameters themselves. | ||
| struct GenericInstance : Printable<GenericInstance> { | ||
| // Values corresponding to a region of a generic. |
There was a problem hiding this comment.
What's a region of a generic? I don't see the term used in the design.
There was a problem hiding this comment.
Sorry, I'd incompletely removed this. Will be introduced in a future PR, gone for now :)
Also add a corresponding value store and YAML output.
We don't create any generic instances in this change; this is just adding infrastructure for future changes.