Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Python type hinting to be PEP-585 Compliant #4083

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

jrmccluskey
Copy link
Contributor

Python PEP-585 replaces a number of typing module types with built-in equivalents and collections.abc versions as of Python 3.9, with the aim of eventually removing the typing module versions of these classes altogether. Since the minimum required version of Python listed in the Contribution Tools document is 3.9, the type hints in the various python files in the repo can be updated to this style of type hint without a need for backwards compatibility.

Feel free to close if this isn't a desired change at this time!

Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

github_tools/pr_comments.py Outdated Show resolved Hide resolved
Co-authored-by: Jon Ross-Perkins <[email protected]>
@jonmeow jonmeow enabled auto-merge June 26, 2024 19:11
@jonmeow jonmeow added this pull request to the merge queue Jun 26, 2024
Merged via the queue into carbon-language:trunk with commit 319c3ca Jun 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants