Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C++-like while loops #340

Merged
merged 17 commits into from
Apr 21, 2021
Merged

Add C++-like while loops #340

merged 17 commits into from
Apr 21, 2021

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Mar 4, 2021 •
edited
Loading

Add C++-like while loops

  • Omits variable declarations in condition syntax (while (auto x = DoSomething())).

@jonmeow jonmeow added WIP proposal A proposal labels Mar 4, 2021
@jonmeow
Copy link
Contributor Author

jonmeow commented Mar 4, 2021 •
edited
Loading

Proposal links (add links as proposal evolves):

@google-cla google-cla bot added cla: yes PR meets CLA requirements according to bot. labels Mar 4, 2021
@jonmeow jonmeow changed the title while loops while loops Mar 4, 2021
@jonmeow jonmeow added proposal rfc Proposal with request-for-comment sent out and removed WIP labels Mar 4, 2021
tkoeppe
tkoeppe reviewed Mar 4, 2021
View reviewed changes
proposals/p0340.md Outdated Show resolved Hide resolved
zygoloid
zygoloid reviewed Mar 8, 2021
View reviewed changes
proposals/p0340.md Outdated Show resolved Hide resolved
jsiek
jsiek reviewed Mar 10, 2021
View reviewed changes
proposals/p0340.md Outdated Show resolved Hide resolved
@jonmeow jonmeow requested a review from a team March 15, 2021 21:00
@jonmeow jonmeow modified the milestones: Proposal WIP, Proposal RFC Mar 17, 2021
austern
austern reviewed Mar 29, 2021
View reviewed changes
proposals/p0340.md Show resolved Hide resolved
proposals/p0340.md Outdated Show resolved Hide resolved
proposals/p0340.md Outdated Show resolved Hide resolved
proposals/p0340.md Show resolved Hide resolved
@jonmeow jonmeow changed the title while loops c++-like while loops Apr 13, 2021
@jonmeow jonmeow changed the title c++-like while loops C++-like while loops Apr 13, 2021
@jonmeow jonmeow changed the title C++-like while loops Add C++-like while loops Apr 13, 2021
@zygoloid zygoloid mentioned this pull request Apr 17, 2021
Merged
zygoloid added a commit that referenced this pull request Apr 20, 2021
@zygoloid
Parsing for while, break, and continue statements, following #340.
2cf976f
@jonmeow jonmeow requested a review from a team as a code owner April 20, 2021 16:00
@chandlerc chandlerc self-assigned this Apr 20, 2021
chandlerc
chandlerc approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks uncontroversial, well supported, and has no blocking issues. Josh did a thorough review (thanks!) and I've tidied up the PR log just to make sure I didn't miss anything.

This LGTM, and approving for the leads. I think this can merge now.

@jonmeow jonmeow merged commit a054365 into carbon-language:trunk Apr 21, 2021
@jonmeow jonmeow deleted the proposal-while-loops branch April 21, 2021 17:06
@jonmeow jonmeow added proposal accepted Decision made, proposal accepted and removed proposal rfc Proposal with request-for-comment sent out labels Apr 21, 2021
@jonmeow jonmeow mentioned this pull request Apr 21, 2021
Open
@github-actions github-actions bot added proposal rfc Proposal with request-for-comment sent out and removed proposal accepted Decision made, proposal accepted labels Apr 22, 2021
@github-actions github-actions bot added proposal deferred Decision made, proposal deferred proposal accepted Decision made, proposal accepted and removed proposal rfc Proposal with request-for-comment sent out proposal deferred Decision made, proposal deferred labels Apr 22, 2021
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@zygoloid
Parsing for while, break, and continue statements, following #340.
153d92b
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@jonmeow
Add C++-like while loops (#340)
7e81fb9 
Add C++-like `while` loops

- Omits variable declarations in condition syntax (`while (auto x = DoSomething())`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh11b josh11b josh11b left review comments

@tkoeppe tkoeppe tkoeppe left review comments

@jsiek jsiek jsiek left review comments

@austern austern austern left review comments

@zygoloid zygoloid zygoloid left review comments

@chandlerc chandlerc chandlerc approved these changes

Assignees

@chandlerc chandlerc

Labels
cla: yes PR meets CLA requirements according to bot. proposal accepted Decision made, proposal accepted proposal A proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jonmeow @zygoloid @chandlerc @austern @jsiek @tkoeppe @josh11b @mmdriley