Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types are values of type type #2360

Merged
merged 25 commits into from
Dec 22, 2022
Merged

Types are values of type type #2360

merged 25 commits into from
Dec 22, 2022

Commits on Oct 28, 2022

  1. Filling out template with PR 2360

    @zygoloid
    zygoloid committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    7cf53a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2022

  1. Initial proposal draft.

    @zygoloid
    zygoloid committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    a7a6ad1 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Update proposals/p2360.md 

    Co-authored-by: Chandler Carruth <[email protected]>
    @zygoloid @chandlerc
    zygoloid and chandlerc authored Oct 31, 2022
    Configuration menu
    Copy the full SHA
    4e47068 View commit details
    Browse the repository at this point in the history

  2. Update proposals/p2360.md 

    Co-authored-by: josh11b <[email protected]>
    @zygoloid @josh11b
    zygoloid and josh11b authored Oct 31, 2022
    Configuration menu
    Copy the full SHA
    3196819 View commit details
    Browse the repository at this point in the history

  3. Update proposals/p2360.md 

    Co-authored-by: Jon Ross-Perkins <[email protected]>
    @zygoloid @jonmeow
    zygoloid and jonmeow authored Oct 31, 2022
    Configuration menu
    Copy the full SHA
    68dcd22 View commit details
    Browse the repository at this point in the history

  4. Responses to review comments.

    @zygoloid
    zygoloid committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    0f73ca8 View commit details
    Browse the repository at this point in the history

  5. Rephrase a little more.

    @zygoloid
    zygoloid committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    fa70880 View commit details
    Browse the repository at this point in the history

  6. Improve terminology.

    @zygoloid
    zygoloid committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    5ba05bc View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Updates based on design discussion and feedback.

    @zygoloid
    zygoloid committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    496b8c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. More updates based on feedback. 

    Add a bunch of examples.
    @zygoloid
    zygoloid committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    525a0ee View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Attempt to improve definition of _facet type_.

    @zygoloid
    zygoloid committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    67031ba View commit details
    Browse the repository at this point in the history

  2. Fix wrong issue number in reference.

    @zygoloid
    zygoloid authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    df800b5 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: josh11b <[email protected]>
Co-authored-by: Chandler Carruth <[email protected]>
    @zygoloid @josh11b @chandlerc
    3 people authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    3816f73 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: josh11b <[email protected]>
    @zygoloid @josh11b
    zygoloid and josh11b authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    08dc2bf View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Add rationale for not defining type in the library.

    @zygoloid
    zygoloid committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    ea8c2de View commit details
    Browse the repository at this point in the history

  2. Reformat.

    @zygoloid
    zygoloid committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    aeb4532 View commit details
    Browse the repository at this point in the history

  3. Say that it's an open question whether constraint Foo {} should mean 

    that `Foo` is the same thing as `type`.
    @zygoloid
    zygoloid committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    3890809 View commit details
    Browse the repository at this point in the history

  4. Mention issue for leads carbon-language#2409.

    @zygoloid
    zygoloid committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    e1cbd51 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2022

  1. Checkpoint progress.

    @josh11b
    josh11b committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    132acc6 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Fix formatting

    @josh11b
    josh11b committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    1a70443 View commit details
    Browse the repository at this point in the history

  2. Clean up rationale in alternative

    @josh11b
    josh11b committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    35bd2ed View commit details
    Browse the repository at this point in the history

  3. Start on teachability

    @josh11b
    josh11b committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    1d65c9a View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2022

  1. Responses to review comments.

    @zygoloid
    zygoloid committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    6d690a1 View commit details
    Browse the repository at this point in the history

  2. Add additional discussion link 

    Co-authored-by: josh11b <[email protected]>
    @zygoloid @josh11b
    zygoloid and josh11b authored Dec 17, 2022
    Configuration menu
    Copy the full SHA
    6079749 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Update proposals/p2360.md 

    Co-authored-by: Chandler Carruth <[email protected]>
    @josh11b @chandlerc
    josh11b and chandlerc authored Dec 22, 2022
    Configuration menu
    Copy the full SHA
    7a30d2d View commit details
    Browse the repository at this point in the history