-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decision for p107 "Code and Name Organization" #174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create initial decision doc.
jonmeow
approved these changes
Oct 14, 2020
chandlerc
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (only tweaks below)
jonmeow
reviewed
Oct 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor edits, as chandlerc pointed out
Co-authored-by: Jon Meow <[email protected]>
Co-authored-by: Jon Meow <[email protected]>
Co-authored-by: Chandler Carruth <[email protected]>
Co-authored-by: Jon Meow <[email protected]>
Co-authored-by: Jon Meow <[email protected]>
chandlerc
added a commit
that referenced
this pull request
Jun 28, 2022
* Decision for p107 "Code and Name Organization" Create initial decision doc. * Update proposals/p107_decision.md Co-authored-by: Jon Meow <[email protected]> * Update proposals/p107_decision.md Co-authored-by: Jon Meow <[email protected]> * Update proposals/p107_decision.md Co-authored-by: Chandler Carruth <[email protected]> * Update proposals/p107_decision.md Co-authored-by: Jon Meow <[email protected]> * Update proposals/p107_decision.md Co-authored-by: Jon Meow <[email protected]> Co-authored-by: Jon Meow <[email protected]> Co-authored-by: Chandler Carruth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla: yes
PR meets CLA requirements according to bot.
proposal accepted
Decision made, proposal accepted
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decision fo proposal p107 "Code name and organization"
Proposal PR
RFC
Decision thread
Approved on 2020-10-06