Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design direction for sum types #157

Merged
merged 29 commits into from
Feb 10, 2021
Merged

Design direction for sum types #157

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
a873000
Initial draft of "Design direction for sum types"
geoffromer Sep 8, 2020
483166f
Move proposal to numbered file
geoffromer Sep 8, 2020
ab67a8e
Respond to review comments and other feedback.
geoffromer Sep 11, 2020
e536993
Minor cleanup of FIXMEs
geoffromer Sep 11, 2020
7783cb6
Respond to reviewer comments.
geoffromer Sep 15, 2020
6cab1d9
Switch proposal to make conversion to `StorageArray` explicit, and co…
geoffromer Sep 25, 2020
a428835
Extensive overhaul of sum types proposal:
geoffromer Oct 30, 2020
2431758
Respond to reviewer feedback.
geoffromer Oct 30, 2020
4cdb352
Apply suggestions from code review
geoffromer Nov 2, 2020
b00255a
Respond to reviewer comments.
geoffromer Nov 3, 2020
47d627e
Switch `Storage` to represent whole buffers, not individual bytes. Al…
geoffromer Nov 12, 2020
60d00d1
Explain how special members can be generated automatically.
geoffromer Nov 12, 2020
c1c08f1
Respond to reviewer comments
geoffromer Nov 12, 2020
0afe466
Draft discussion of "Pattern matching proxies" alternative.
geoffromer Nov 13, 2020
80bac79
Initial sketch of callback-based approach
geoffromer Nov 17, 2020
026aba8
Discuss callback-based approach in depth, and focus on it as the lead…
geoffromer Dec 1, 2020
4dbd31d
Respond to reviewer comments, and delete redundant/inaccurate discuss…
geoffromer Dec 1, 2020
bdaac53
Pivot to make "Pattern matching callbacks" the primary proposal, and …
geoffromer Dec 14, 2020
8b8fb3a
Respond to reviewer comment.
geoffromer Dec 14, 2020
6010589
Respond to reviewer comments.
geoffromer Jan 11, 2021
581267c
Apply suggestions from code review
geoffromer Jan 11, 2021
8ffcba5
Respond to reviewer comments
geoffromer Jan 14, 2021
9e1ba63
Add discussion of how to distinguish patterns from expressions, and m…
geoffromer Jan 18, 2021
0e988ef
Expand the discussion of the drawbacks of the "Designator types" appr…
geoffromer Jan 18, 2021
e14d693
Respond to reviewer comments.
geoffromer Jan 21, 2021
e4bb86d
Respond to reviewer comments.
geoffromer Jan 21, 2021
2ab98c2
Respond to reviewer comments
geoffromer Feb 3, 2021
875d8cf
Merge branch 'trunk' into direction
geoffromer Feb 10, 2021
468a65a
Fix presubmit failure.
geoffromer Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions proposals/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@ request:
- [Decision](p0074_decision.md)
- [0083 - In-progress design overview](p0083.md)
- [0120 - Add idiomatic code performance and developer-facing docs to goals](p0120.md)
- [0157 - Design direction for sum types](p0157.md)

<!-- endproposals -->
Loading