Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert first Print argument to String before evaluating #1548

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Convert first Print argument to String before evaluating #1548

merged 4 commits into from
Jul 27, 2022

Conversation

tkadur
Copy link
Contributor

@tkadur tkadur commented Jul 22, 2022

Fixes #1439.

@tkadur tkadur marked this pull request as ready for review July 22, 2022 06:04
@chandlerc chandlerc requested a review from zygoloid July 22, 2022 23:36
jonmeow
jonmeow approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good, just one small request on the test location.

explorer/testdata/string/associated_constant.carbon Outdated Show resolved Hide resolved
@jonmeow jonmeow merged commit 790e075 into carbon-language:trunk Jul 27, 2022
@tkadur tkadur deleted the fix-explorer-print branch July 28, 2022 21:34
@chandlerc chandlerc added the explorer Action items related to Carbon explorer code label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmeow jonmeow jonmeow approved these changes

@zygoloid zygoloid Awaiting requested review from zygoloid

Assignees
No one assigned
Labels
explorer Action items related to Carbon explorer code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

explorer has lifetime(?) bug with String associated constants
3 participants
@tkadur @jonmeow @chandlerc