Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generics: impl forall #1327

Merged
merged 4 commits into from
Jun 15, 2022
Merged

Generics: impl forall #1327

merged 4 commits into from
Jun 15, 2022

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Jun 13, 2022 •
edited
Loading

Implement the decision in #1192 to use this syntax for parameterized impls:

impl forall [generic parameters] type as constraint ...

@josh11b josh11b added the proposal A proposal label Jun 13, 2022
@josh11b josh11b requested a review from a team June 13, 2022 20:35
@josh11b josh11b marked this pull request as ready for review June 13, 2022 22:06
@josh11b josh11b requested a review from a team as a code owner June 13, 2022 22:06
@github-actions github-actions bot added the proposal rfc Proposal with request-for-comment sent out label Jun 13, 2022
chandlerc
chandlerc approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Given the already made decision, I think this is good to go.

@chandlerc chandlerc merged commit 313a50c into carbon-language:trunk Jun 15, 2022
@chandlerc chandlerc deleted the forall branch June 15, 2022 02:35
@github-actions github-actions bot added proposal accepted Decision made, proposal accepted and removed proposal rfc Proposal with request-for-comment sent out labels Jun 15, 2022
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@josh11b
Generics: impl forall (#1327)
b83f5c3 
Implement the decision in #1192 to use this syntax for parameterized impls:

> `impl forall [`_generic parameters_`]` _type_ `as` _constraint_ ...
@josh11b josh11b mentioned this pull request Oct 8, 2022
Merged
@chandlerc chandlerc added the documentation An issue or proposed change to our documentation label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerc chandlerc chandlerc approved these changes

Assignees
No one assigned
Labels
documentation An issue or proposed change to our documentation proposal accepted Decision made, proposal accepted proposal A proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josh11b @chandlerc