Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitwise operators #1191

Merged
merged 17 commits into from
May 6, 2022
Merged

Bitwise operators #1191

merged 17 commits into from
May 6, 2022

Conversation

zygoloid
Copy link
Contributor

@zygoloid zygoloid commented Apr 16, 2022

Add bitwise and bit-shift operators &, |, ^, <<, >>. Replace C++ ~ with unary prefix ^.

@zygoloid zygoloid added the proposal A proposal label Apr 16, 2022
@zygoloid zygoloid requested a review from a team April 16, 2022 01:10
@zygoloid zygoloid marked this pull request as ready for review April 22, 2022 04:47
@zygoloid zygoloid requested a review from a team as a code owner April 22, 2022 04:47
@github-actions github-actions bot added the proposal rfc Proposal with request-for-comment sent out label Apr 22, 2022
docs/design/expressions/README.md Show resolved Hide resolved
docs/design/expressions/README.md Outdated Show resolved Hide resolved
docs/design/expressions/bitwise.md Show resolved Hide resolved
docs/design/expressions/bitwise.md Show resolved Hide resolved
docs/design/expressions/bitwise.md Outdated Show resolved Hide resolved
proposals/p1191.md Outdated Show resolved Hide resolved
proposals/p1191.md Show resolved Hide resolved
docs/design/expressions/README.md Show resolved Hide resolved
docs/design/expressions/README.md Show resolved Hide resolved
proposals/p1191.md Show resolved Hide resolved
proposals/p1191.md Outdated Show resolved Hide resolved
docs/design/expressions/bitwise.md Outdated Show resolved Hide resolved
proposals/p1191.md Outdated Show resolved Hide resolved
proposals/p1191.md Show resolved Hide resolved
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting some added detail in the alternatives considered to more fully cover concerns raised on the decision here.

proposals/p1191.md Outdated Show resolved Hide resolved
proposals/p1191.md Outdated Show resolved Hide resolved
proposals/p1191.md Show resolved Hide resolved
proposals/p1191.md Show resolved Hide resolved
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot! Confirmed on Discord that the outstanding comment threads were addressed, and this looks good to land, merging!

@chandlerc chandlerc merged commit 87c7449 into carbon-language:trunk May 6, 2022
@chandlerc chandlerc deleted the proposal-bitwise-operators branch May 6, 2022 21:26
@github-actions github-actions bot added proposal accepted Decision made, proposal accepted and removed proposal rfc Proposal with request-for-comment sent out labels May 6, 2022
chandlerc added a commit that referenced this pull request Jun 28, 2022
Add bitwise and bit-shift operators `&`, `|`, `^`, `<<`, `>>`. Replace C++ `~` with unary prefix `^`.

Co-authored-by: Chandler Carruth <[email protected]>
zygoloid added a commit to zygoloid/carbon-lang that referenced this pull request Jul 28, 2022
Following carbon-language#1191, add initial support for bitwise operators. Support for both
integer operations and for operator overloading via the interfaces specified in
carbon-language#1191 is provided.
zygoloid added a commit that referenced this pull request Jul 31, 2022
Following #1191, add initial support for bitwise operators. Support for both
integer operations and for operator overloading via the interfaces specified in
#1191 is provided.

Co-authored-by: Jon Ross-Perkins <[email protected]>
SlaterLatiao pushed a commit to SlaterLatiao/carbon-lang that referenced this pull request Aug 3, 2022
Following carbon-language#1191, add initial support for bitwise operators. Support for both
integer operations and for operator overloading via the interfaces specified in
carbon-language#1191 is provided.

Co-authored-by: Jon Ross-Perkins <[email protected]>
@chandlerc chandlerc added the documentation An issue or proposed change to our documentation label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation An issue or proposed change to our documentation proposal accepted Decision made, proposal accepted proposal A proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants