-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic details 10: interface-implemented requirements #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh11b
changed the title
Generic details 10: interface implemented requirements
Generic details 10: interface-implemented requirements
Mar 5, 2022
github-actions
bot
added
the
proposal rfc
Proposal with request-for-comment sent out
label
Mar 7, 2022
zygoloid
reviewed
Mar 9, 2022
zygoloid
reviewed
Apr 27, 2022
Co-authored-by: Richard Smith <[email protected]>
zygoloid
reviewed
May 5, 2022
zygoloid
approved these changes
May 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. A couple of minor suggestions; please feel free to merge once they're handled.
Co-authored-by: Richard Smith <[email protected]>
github-actions
bot
added
proposal accepted
Decision made, proposal accepted
and removed
proposal rfc
Proposal with request-for-comment sent out
labels
May 5, 2022
chandlerc
pushed a commit
that referenced
this pull request
Jun 28, 2022
This proposal: - Adds support for interfaces requiring other types than `Self` to implement interfaces, as in: ``` interface IntLike { impl i32 as As(Self); // ... } ``` - Defines requirements on how to satisfy those requirements that have a `where` clause. - Extends `observe` declarations to include saying a type implements an interface, so code can provide a proof instead of the compiler having to perform a recursive search. Co-authored-by: Richard Smith <[email protected]>
chandlerc
added
the
documentation
An issue or proposed change to our documentation
label
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
An issue or proposed change to our documentation
proposal accepted
Decision made, proposal accepted
proposal
A proposal
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal:
Self
to implement interfaces, as in:where
clause.observe
declarations to include saying a type implements an interface, so code can provide a proof instead of the compiler having to perform a recursive search.