Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code and name organization #107
Code and name organization #107
Changes from 58 commits
2ae6b6f
5bba3a8
98562a6
a05e9c3
dfe42cb
3931951
43cfde9
b489c23
5b10b4d
6ce0f97
218df9f
5c33fbf
160b5c4
5829ac9
8692c9a
6b7f469
654cad6
aa96aaf
ca5d5bd
c132018
3d99524
5813814
3154969
a546035
1222334
3cebea3
4bbba84
d7d2850
7c4c32c
d5b8ab9
3e15730
e578b1f
5319498
06dea5d
bf74c75
9559bec
af6f4b1
2311f03
db2d550
1ebecc1
54f740b
cf53d74
0d81ff4
03f92f8
a5c4e16
8d62937
1d09728
9fed213
b53a98d
50cb15b
1e55c4f
365a089
0c6c6de
8297dbe
eae6a9b
2111545
23bee19
94bd816
69d1893
4f10ddb
e56549e
1cec071
99801c1
91f989e
559677b
7c464a5
e1c46e3
60dfa21
c8ea9bb
578591b
84cd55f
882d5e0
7a0a400
f914c1b
d0ba98a
b8f9fc2
53a1072
0da274b
16ba315
687c166
31a7619
6efd78e
4d15065
441fe24
6d9f997
d9a7b34
71375af
6c4d9e3
9607815
06b31f5
8a5b20b
79270d3
754cb6b
0388e5b
3c52bb7
2a1a662
e9f4404
3ef6558
f71c05d
cd6e7b4
fe4c7d2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked this list because it gave succinct definitions of the concepts at the beginning of the section. Was it incorrect? If so, can we correct or improve it, instead of deleting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rephrased the paragraph on line 134 as bullets.
Note here, this may end up going back again: it changed to a paragraph based on other feedback on writing styles. I'm not heavily opinionated, but I won't provide the same information both ways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A semicolon-terminated namespace declaration is not very clear about how it combines with other namespace declarations. Specifically, does it override the
namespace Shapes
above, or does it create a nested namespace withinShapes
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think line 140 covers this:
Geometry.Shapes.Flat.Circle
, meaning a nested namespace. Keep in mind that this is the overview, so won't go into deep detail.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The definition of the type seems to place it in the library called
OneSide
, notTriangle
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed