Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and, or, and not from #680 #1032

Merged
merged 14 commits into from
Jan 27, 2022
Merged

Document and, or, and not from #680 #1032

merged 14 commits into from
Jan 27, 2022

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Jan 18, 2022

No description provided.

@jonmeow jonmeow requested a review from zygoloid January 18, 2022 23:59
@jonmeow jonmeow requested review from a team as code owners January 18, 2022 23:59
@jonmeow
Copy link
Contributor Author

jonmeow commented Jan 19, 2022

I'm planning on doing this then #702 then #555, in that order, because of overlap.

josh11b
josh11b reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@josh11b josh11b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me

docs/design/expressions/logical_operators.md Outdated Show resolved Hide resolved
docs/design/expressions/logical_operators.md Outdated Show resolved Hide resolved
josh11b
josh11b reviewed Jan 19, 2022
View reviewed changes
docs/design/expressions/logical_operators.md Outdated Show resolved Hide resolved
docs/design/expressions/logical_operators.md Outdated Show resolved Hide resolved
docs/design/expressions/logical_operators.md Outdated Show resolved Hide resolved
zygoloid
zygoloid reviewed Jan 19, 2022
View reviewed changes
docs/design/expressions/README.md Outdated Show resolved Hide resolved
docs/design/expressions/logical_operators.md Outdated Show resolved Hide resolved
jonmeow
jonmeow commented Jan 20, 2022
View reviewed changes
Copy link
Contributor Author

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment pass

docs/design/expressions/logical_operators.md Outdated Show resolved Hide resolved
docs/design/expressions/logical_operators.md Outdated Show resolved Hide resolved
docs/design/expressions/README.md Outdated Show resolved Hide resolved
docs/design/expressions/logical_operators.md Outdated Show resolved Hide resolved
docs/design/expressions/logical_operators.md Outdated Show resolved Hide resolved
chandlerc
chandlerc reviewed Jan 20, 2022
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Some minor clarifications/fixes inline. Happy with this whenever others are.

docs/design/expressions/README.md Outdated Show resolved Hide resolved
docs/design/expressions/README.md Outdated Show resolved Hide resolved
docs/design/expressions/logical_operators.md Outdated Show resolved Hide resolved
jonmeow
jonmeow commented Jan 20, 2022
View reviewed changes
Copy link
Contributor Author

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment pass

docs/design/expressions/README.md Outdated Show resolved Hide resolved
docs/design/expressions/README.md Outdated Show resolved Hide resolved
chandlerc
chandlerc approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I still have some questions about "as expressions" vs. "as operator" but I don't think that needs to get resolved here, this already seems like a good step so LGTM. We can fix-forward from here easily.

@jonmeow jonmeow merged commit 2fc4d10 into carbon-language:trunk Jan 27, 2022
@jonmeow jonmeow deleted the logical-ops branch January 27, 2022 19:19
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@jonmeow @zygoloid
Document and, or, and not from #680 (#1032)
6218aff 
Co-authored-by: Chandler Carruth <[email protected]>

Co-authored-by: Richard Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh11b josh11b josh11b left review comments

@chandlerc chandlerc chandlerc approved these changes

@zygoloid zygoloid Awaiting requested review from zygoloid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonmeow @zygoloid @chandlerc @josh11b