Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect "Comments #198" in the design docs #1994

Closed
josh11b opened this issue Aug 11, 2022 · 16 comments · Fixed by #2641
Closed

Reflect "Comments #198" in the design docs #1994

josh11b opened this issue Aug 11, 2022 · 16 comments · Fixed by #2641
Labels
good first issue Possibly a good first issue for newcomers long term Issues expected to take over 90 days to resolve.

Comments

@josh11b
Copy link
Contributor

josh11b commented Aug 11, 2022

Proposal #198 was accepted but https://github.com/carbon-language/carbon-lang/tree/trunk/docs/design/lexical_conventions/README.md still says "TODO: ... comments", and that should be linked from https://github.com/carbon-language/carbon-lang/blob/trunk/docs/design/README.md#code-and-comments . Since the design decision in #198 is somewhat surprising, it would be good to explain it and possibly the alternatives considered somewhere in the lexical_conventions directory.

@josh11b josh11b added the good first issue Possibly a good first issue for newcomers label Aug 12, 2022
@avinal
Copy link
Contributor

avinal commented Aug 12, 2022

Hello @josh11b, I would like to work on this issue.

@josh11b
Copy link
Contributor Author

josh11b commented Aug 12, 2022

Hello @josh11b, I would like to work on this issue.

Sounds good! You'll want to make sure you sign up for contributor access, see https://github.com/carbon-language/carbon-lang/blob/trunk/CONTRIBUTING.md#collaboration-systems .

@avinal
Copy link
Contributor

avinal commented Aug 13, 2022

I have requested contributor access. In the meantime, I am going through the discussions.

@jonmeow
Copy link
Contributor

jonmeow commented Aug 15, 2022

FYI: creating PRs doesn't require contributor access (see the last paragraph of getting access for an explanation of what access is appropriate when)

@github-actions
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please comment or remove the inactive label. The long term label can also be added for issues which are expected to take time.
This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Issues and PRs which have been inactive for at least 90 days. label Nov 14, 2022
@avinal
Copy link
Contributor

avinal commented Nov 14, 2022

Will add by this weekend.

@github-actions github-actions bot removed the inactive Issues and PRs which have been inactive for at least 90 days. label Nov 15, 2022
@eeshvardasikcm
Copy link

Is there any additional help needed on this issue? I can dedicate time next week to help. I can check in on this issue in Discord Monday morning.

@josh11b
Copy link
Contributor Author

josh11b commented Dec 16, 2022

Is there any additional help needed on this issue? I can dedicate time next week to help. I can check in on this issue in Discord Monday morning.

@eeshvardasikcm , it looks like @avinal created #2064 but did not finish it. I am not aware of anyone else working on this.

@avinal
Copy link
Contributor

avinal commented Dec 16, 2022

Hey @josh11b @eeshvardasikcm, apologies for not being able to complete this till now, last few months were very busy. I don't have access to a system till 20th Dec, as soon I get back, I will push my changes. Also no additional help is required AFIR, if something comes up I will ping you. Thanks for your understanding.

@eeshvardasikcm
Copy link

...I will push my changes. Also no additional help is required...

Okay. There's a different issue that I can do. Thanks for the update. josh11b is monitoring this issue.

@josh11b josh11b added the long term Issues expected to take over 90 days to resolve. label Dec 21, 2022
@aswin2108
Copy link
Contributor

@avinal @josh11b Can I try it...?

@amyra98
Copy link

amyra98 commented Feb 28, 2023

Can you please explain in detail what do I have to do? @josh11b and then assign me this issue

@aswin2108
Copy link
Contributor

@amyra98 Actually I am working on this and will create a pr shortly!

@KAWALMEET-SINGH
Copy link

I want to work on this Issue please assign me.

@jonmeow
Copy link
Contributor

jonmeow commented Mar 10, 2023

@KAWALMEET-SINGH We typically won't assign issues. I've added some documentation for why. Please feel to work on it if you have time [a "good first issue" can help familiarize with the project], but please note aswin2108 recently sent out #2641.

@aswin2108
Copy link
Contributor

Yeah, actually I was waiting for the review to happen! I was said that it was in the queue.

jonmeow pushed a commit that referenced this issue Mar 30, 2023
The [Comments #198](#198) got accepted but the details were not updated in the design docs. Added `comments.md` file to add the details of the proposal and its discussion.

Closes #1994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Possibly a good first issue for newcomers long term Issues expected to take over 90 days to resolve.
Projects
None yet
7 participants