Skip to content

Commit

Permalink
Mark some leaf classes final to suppress -Wnon-virtual-dtor. (#4141)
Browse files Browse the repository at this point in the history
  • Loading branch information
zygoloid authored Jul 17, 2024
1 parent 579cd3b commit e6860d9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion toolchain/check/generic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ static auto AddGenericConstantToEvalBlock(
namespace {
// Substitution callbacks to rebuild a generic type in the eval block for a
// generic region.
class RebuildGenericTypeInEvalBlockCallbacks : public SubstInstCallbacks {
class RebuildGenericTypeInEvalBlockCallbacks final : public SubstInstCallbacks {
public:
RebuildGenericTypeInEvalBlockCallbacks(
Context& context, SemIR::GenericId generic_id,
Expand Down
2 changes: 1 addition & 1 deletion toolchain/check/subst.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ auto SubstInst(Context& context, SemIR::InstId inst_id,
namespace {
// Callbacks for performing substitution of a set of Substitutions into a
// symbolic constant.
class SubstConstantCallbacks : public SubstInstCallbacks {
class SubstConstantCallbacks final : public SubstInstCallbacks {
public:
SubstConstantCallbacks(Context& context, Substitutions substitutions)
: context_(context), substitutions_(substitutions) {}
Expand Down

0 comments on commit e6860d9

Please sign in to comment.