Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): add ListBox styles #659

Merged
merged 1 commit into from
Jul 8, 2020
Merged

fix(dropdown): add ListBox styles #659

merged 1 commit into from
Jul 8, 2020

Conversation

SimonFinney
Copy link
Contributor

Affected issue

Resolves #658

Proposed changes

  • Add ListBox style import
  • Add ListBox style as dependency for Dropdown
  • Remove override resolved in Carbon upgrade

@SimonFinney SimonFinney requested a review from a team as a code owner July 8, 2020 09:23
@SimonFinney SimonFinney requested a review from jendowns July 8, 2020 09:23
@netlify
Copy link

netlify bot commented Jul 8, 2020

Deploy preview for ibm-security ready!

Built with commit 920ca5e

https://deploy-preview-659--ibm-security.netlify.app

@SimonFinney
Copy link
Contributor Author

Workaround for carbon-design-system/carbon#6414

@jendowns jendowns merged commit 644c389 into dev Jul 8, 2020
@jendowns jendowns deleted the 658/isolated-dropdown branch July 8, 2020 14:52
SimonFinney pushed a commit that referenced this pull request Jul 8, 2020
## [1.27.1-prerelease.1](v1.27.0...v1.27.1-prerelease.1) (2020-07-08)

### Bug Fixes

* **dropdown:** add `ListBox` styles ([#659](#659)) ([644c389](644c389))
@SimonFinney
Copy link
Contributor Author

🎉 This PR is included in version 1.27.1-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

SimonFinney pushed a commit that referenced this pull request Jul 21, 2020
# [1.28.0](v1.27.0...v1.28.0) (2020-07-21)

### Bug Fixes

* **checkbox:** update checkbox focus to ensure border is used ([#672](#672)) ([53bd877](53bd877))
* **data-table:** proxy `defaultProps` and `propTypes` ([#666](#666)) ([cf37860](cf37860))
* **decorator:** add character limit, display value in `title` prop ([#654](#654)) ([0adbcfc](0adbcfc))
* **dropdown:** add `ListBox` styles ([#659](#659)) ([644c389](644c389))
* **searchbar:** remove unused Search prop showIcon ([#674](#674)) ([6c5af0b](6c5af0b))
* **truncated-list:** include `ScrollGradient` styles ([#676](#676)) ([1c44825](1c44825))

### Features

* **carbon:** upgrade to `v10.15` ([#660](#660)) ([f328809](f328809))
@SimonFinney
Copy link
Contributor Author

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants