fix(EmptyState): added useId handling for older react version #6607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-anderson-ibm
requested review from
davidmenendez and
sangeethababu9223
and removed request for
a team
|
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
recheck I have read the DCO document and I hereby sign the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
davidmenendez
previously approved these changes
Dec 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6607 +/- ##
==========================================
- Coverage 80.76% 80.75% -0.02%
==========================================
Files 395 396 +1
Lines 12884 12886 +2
Branches 4266 4267 +1
==========================================
Hits 10406 10406
- Misses 2478 2480 +2
|
amal-k-joy
approved these changes
Dec 19, 2024
|
Thanks for contributing this fix @sean-anderson-ibm! 🎉 These commits were merged yesterday into our release branch, see here. And then auto-merged back into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6606
Fixes
useIduse in react 17 and below, due touseIdonly being in react 18 and above. Falls back to previous method of id generation for react versions <18.What did you change?
I added a util function to change how
useIdworks based on react version support and updated references to itHow did you test and verify your work?
I linked the build package to a repo using react 16, and verified the issue was no longer present.
I have read the DCO document and I hereby sign the DCO.