fix(actions): use correct reviewing team name #6549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewgallo
requested review from
davidmenendez and
devadula-nandan
and removed request for
a team
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6549 +/- ##
=======================================
Coverage 79.91% 79.91%
=======================================
Files 394 394
Lines 12888 12888
Branches 4267 4267
=======================================
Hits 10300 10300
Misses 2588 2588
|
davidmenendez
approved these changes
Dec 5, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 5, 2024
2654860
34 checks passed
|
😂 I even left a comment in the code for my future self to update the name and still forgot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another follow up PR to get the PR review label action working. I've confirmed that the auth issues are fixed now but then noticed a 404 for the teams api because I forgot to update the
team_slugwith the name of our reviewing team.One more small change included here is to just specify
APP_INSTALLATION_IDas a valid input to be passed in.What did you change?