fix: datagrid select all behavior in virtual scroll #6546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devadula-nandan
requested review from
sangeethababu9223 and
amal-k-joy
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6546 +/- ##
==========================================
- Coverage 79.97% 79.87% -0.11%
==========================================
Files 394 394
Lines 12894 12904 +10
Branches 4273 4275 +2
==========================================
- Hits 10312 10307 -5
- Misses 2582 2597 +15
|
matthewgallo
approved these changes
Dec 10, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 10, 2024
b80d7f0
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6125
this pr reverts select all logic from #5933, and is conditionally applied on
withVirtualScrollWhat did you change?
reverts previous behavior of select all for virtual scroll configuration of datagrid
How did you test and verify your work?
storybook