Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add generate token step for the dependency upgrade job #6533

Conversation

matthewgallo
Copy link
Member

@matthewgallo matthewgallo commented Dec 3, 2024

This will fix a bug in the recent changes to the dependency upgrade action so that the non-Carbon dependencies have an access token to open a PR.

What did you change?

.github/workflows/update.yml

How did you test and verify your work?

For additional context, see here. You can see that the carbon job passed and a PR was opened successfully by the Carbon automation app/bot but the second job failed.

@matthewgallo matthewgallo requested review from elycheea, kennylam and a team as code owners December 3, 2024 21:22
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 2801ebc
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/674f768f314a8e0008de4818
😎 Deploy Preview https://deploy-preview-6533--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 2801ebc
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/674f768fce6d920008b23359
😎 Deploy Preview https://deploy-preview-6533--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elycheea elycheea added this pull request to the merge queue Dec 3, 2024
Merged via the queue into carbon-design-system:main with commit 4609cd9 Dec 3, 2024
32 checks passed
@matthewgallo matthewgallo deleted the add-token-gen-step-for-dependency-job branch December 3, 2024 21:53
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (b2298b5) to head (2801ebc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6533      +/-   ##
==========================================
- Coverage   79.88%   79.86%   -0.03%     
==========================================
  Files         394      394              
  Lines       12877    12877              
  Branches     4258     4258              
==========================================
- Hits        10287    10284       -3     
- Misses       2590     2593       +3     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants