Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Tagset): add avt tests for complex states #6524

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

amal-k-joy
Copy link
Contributor

Closes #6473

  • Test latest accessibility-checker rulesets on various states of tag set
  • Add tests for open and close states in popover/tooltip
  • Add tests for open and close states in tag modal
  • Review any additional states we may need to capture or add tests for : covered remove tags functionality and search functionality in the modal.
  • Add keyboard navigation tests to AVT

How did you test and verify your work?

yarn avt

@amal-k-joy amal-k-joy requested a review from a team as a code owner December 3, 2024 07:14
@amal-k-joy amal-k-joy requested review from davidmenendez and anamikaanu96 and removed request for a team December 3, 2024 07:14
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 29679f7
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/67515efa1065a200081f26db
😎 Deploy Preview https://deploy-preview-6524--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 29679f7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/67515efa9b46d40008e6c6da
😎 Deploy Preview https://deploy-preview-6524--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amal-k-joy amal-k-joy enabled auto-merge December 3, 2024 07:15
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.92%. Comparing base (3f45528) to head (29679f7).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6524      +/-   ##
==========================================
+ Coverage   79.85%   79.92%   +0.07%     
==========================================
  Files         394      394              
  Lines       12877    12888      +11     
  Branches     4258     4267       +9     
==========================================
+ Hits        10283    10301      +18     
+ Misses       2594     2587       -7     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! just one small suggestion

e2e/components/TagSet/TagSet-test.avt.e2e.js Outdated Show resolved Hide resolved
davidmenendez
davidmenendez previously approved these changes Dec 4, 2024
Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! well done

@davidmenendez
Copy link
Contributor

looks like you forgot to include the copyright header in the new util file

Error: Cannot find license text in: e2e/test-utils/simulateKeyPress.ts

Copy link
Contributor

@anamikaanu96 anamikaanu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amal-k-joy amal-k-joy added this pull request to the merge queue Dec 5, 2024
Merged via the queue into carbon-design-system:main with commit 6a90311 Dec 5, 2024
33 checks passed
@amal-k-joy amal-k-joy deleted the tagsetAvt branch December 5, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate TagSet for WCAG 2.2 readiness
3 participants