chore(cards): rename aiLabel to decorator #6509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6509 +/- ##
==========================================
+ Coverage 79.91% 79.98% +0.06%
==========================================
Files 394 394
Lines 12888 12894 +6
Branches 4267 4273 +6
==========================================
+ Hits 10300 10313 +13
+ Misses 2588 2581 -7
|
…ilabel-to-decorator
…ub.com/sangeethababu9223/ibm-products into chore/card-rename-ailabel-to-decorator
sangeethababu9223
requested review from
elycheea and
amal-k-joy
and removed request for
a team
elycheea
reviewed
Nov 27, 2024
elycheea
reviewed
Nov 27, 2024
elycheea
requested changes
Nov 27, 2024
amal-k-joy
requested changes
Dec 3, 2024
I've added a basic test case for the decorator. |
elycheea
reviewed
Dec 3, 2024
| @@ -185,7 +199,8 @@ $block-class: #{c4p-settings.$pkg-prefix}--card; | |||
| } | |||
|
|
|||
| .#{$block-class}__clickable.#{$block-class}--has-slug::before, | |||
| .#{$block-class}__clickable.#{$block-class}--has-ai-label::before { | |||
| .#{$block-class}__clickable.#{$block-class}--has-ai-label::before, | |||
| .#{$block-class}__clickable.#{$block-class}--has-decorator::before { | |||
There was a problem hiding this comment.
Suggested change
| .#{$block-class}__clickable.#{$block-class}--has-decorator::before { | |
| .#{$block-class}__clickable.#{$block-class}--has-decorator::before { |
I think for has--decorator, we don’t want to tie this to the popover styles since this could be separate.
There was a problem hiding this comment.
Thanks @elycheea,
This is updated.
…ilabel-to-decorator
…ub.com/sangeethababu9223/ibm-products into chore/card-rename-ailabel-to-decorator
elycheea
approved these changes
Dec 4, 2024
amal-k-joy
approved these changes
Dec 9, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 9, 2024
6e58e9d
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6452
Rename aiLabel prop to decorator in ExpressiveCard / ProductiveCard
What did you change?
Updated the prop name
aiLabelin Expressive Card, Productive Card and Card files todecorator.Updated the card style to only show gradient styling when
AILabelcomponent is passed.How did you test and verify your work?
Storybook