Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds codecov #6236

Merged

Conversation

AlexanderMelox
Copy link
Contributor

@AlexanderMelox AlexanderMelox commented Oct 16, 2024

Closes #6108

Similar to this PR opened in Carbon core

This PR adds Codecov. Codecov ensures that we comply with test coverage standards and PR reviewers are aware of any coverage changes.

After this PR is merged we will begin seeing Codecov comments on PR's.

Online tooling for Codecov

Screenshot 2024-10-16 at 2 07 46 PM

Note: Codecov is set to coverage target: auto so that code coverage does not fail PR's until we are ready to enforce 80% coverage

What did you change?

+ .github/codecov.yml
+ .github/workflows/ci.yml

Changed

  • Test script now runs with --collectCoverage to push the report to Codecov

How did you test and verify your work?

Next steps

  • Create an issue on increasing Codecov's target coverage percentage

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 0beb5ab
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/6711582ae2688500081a9b09
😎 Deploy Preview https://deploy-preview-6236--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 0beb5ab
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6711582ae49ebc0009afa0f5
😎 Deploy Preview https://deploy-preview-6236--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 17, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@AlexanderMelox
Copy link
Contributor Author

This PR also removes the test-community ci action to align with @davidmenendez PR to avoid conflicts
https://github.com/carbon-design-system/ibm-products/pull/6241/files#

Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@elycheea elycheea added this pull request to the merge queue Oct 18, 2024
Merged via the queue into carbon-design-system:main with commit 0f53889 Oct 18, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement code coverage tooling
3 participants