fix(CreateFullPageStep): hasFieldset and fieldsetLegendText types #6057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fieldsetLegendText should not be required when hasFieldset is not specified. Basically, not specifying hasFieldset is the same thing as setting it to false. Refs carbon-design-system#4512.
wkeese
requested review from
matthewgallo and
AlexanderMelox
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matthewgallo
approved these changes
Sep 16, 2024
davidmenendez
approved these changes
Sep 17, 2024
Merged
via the queue into
carbon-design-system:main
with commit Sep 17, 2024
b5db933
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #4512.
fieldsetLegendTextshould not be required whenhasFieldsetis not specified.Basically, not specifying
hasFieldsetis the same thing as setting it tofalse.What did you change?
When
hasFieldsetis not specified, makefieldsetLegendTextoptional.How did you test and verify your work?
Test locally.