Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(action-bar): convert to typescript #5733

Conversation

ariellalgilmore
Copy link
Member

Closes #5674

add types to actionbar

What did you change?

Update ActionBar, ActionBarItem, and ActioinBarOverflowItems to using typescript

How did you test and verify your work?

storybook

Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 25be42f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66a7ca388d70880008c564f0
😎 Deploy Preview https://deploy-preview-5733--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review July 26, 2024 15:42
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner July 26, 2024 15:42
@ariellalgilmore ariellalgilmore requested review from matthewgallo and amal-k-joy and removed request for a team July 26, 2024 15:42
Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Few minor comments.

@matthewgallo matthewgallo requested a review from amal-k-joy July 31, 2024 14:57
@matthewgallo matthewgallo added this pull request to the merge queue Jul 31, 2024
Merged via the queue into carbon-design-system:main with commit 30b4fdb Jul 31, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Typescript types to ActionBar
3 participants