Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(GetStartedCard): update to typescript #5719

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Jul 24, 2024

Closes #5675

Update GetStartedCard to use types

What did you change?

updated the GetStartedCard file

How did you test and verify your work?

Storybook

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 0856ce0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66a1509b6dd1b8000859300e
😎 Deploy Preview https://deploy-preview-5719--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit c7f63cb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66a150a5fcb786000874aba9
😎 Deploy Preview https://deploy-preview-5719--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review July 25, 2024 00:08
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner July 25, 2024 00:08
@ariellalgilmore ariellalgilmore requested review from davidmenendez and anamikaanu96 and removed request for a team July 25, 2024 00:08
@ariellalgilmore ariellalgilmore changed the title feat(GetStartedCard): update to typescript refactor(GetStartedCard): update to typescript Jul 26, 2024
Copy link
Contributor

@anamikaanu96 anamikaanu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@anamikaanu96 anamikaanu96 added this pull request to the merge queue Jul 29, 2024
Merged via the queue into carbon-design-system:main with commit 7731b3c Jul 29, 2024
21 checks passed
@ariellalgilmore ariellalgilmore deleted the feat/get-started-typescript branch July 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Typescript types to GetStartedCard
3 participants