chore: tagoverflow typescript conversion #5715
Conversation
davidmenendez
requested review from
elycheea and
amal-k-joy
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| onOverflowTagChange = defaults.onOverflowTagChange, | ||
|
|
||
| // Collect any other property values passed in. | ||
| overflowType, |
There was a problem hiding this comment.
Hey, Looks like overflowType is an optional prop and we were using a default value as 'default' , and now you have removed passing default values.
Will that affect the behaviour?
Can we pass just like overflowType = 'default'
Please check other props as well where default values have been removed
| @@ -292,7 +286,7 @@ const tagTypes = Object.keys(TYPES); | |||
| */ | |||
| export const string_required_if_more_than_10_tags = isRequiredIf( | |||
| PropTypes.string, | |||
| ({ items }) => items && items.length > allTagsModalSearchThreshold | |||
| ({ items }) => items && items?.length > allTagsModalSearchThreshold | |||
There was a problem hiding this comment.
Hey , do you think just this is enough, though both works?
({ items }) => items?.length > allTagsModalSearchThreshold
| ); | ||
| }; | ||
|
|
||
| const visibleItems = getOverflowPopoverItems(); | ||
| const hasItems = visibleItems && visibleItems?.length > 0; |
There was a problem hiding this comment.
same comment as above
const hasItems = visibleItems?.length > 0;
|
@amal-k-joy please re-review when you have a chance. ty! |
| id: string; | ||
| label: string; | ||
| onClose: () => void; | ||
| tagType?: |
There was a problem hiding this comment.
If possible we should try to import this from @carbon/react.
| maxVisible?: number; | ||
| measurementOffset?: number; | ||
| multiline?: boolean; | ||
| overflowAlign?: |
There was a problem hiding this comment.
If possible we should try to import this from @carbon/react.
35ea4c4
Closes #5673