refactor(EmptyState): add types to EmptyState #5711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
annawen1
requested review from
davidmenendez and
anamikaanu96
and removed request for
a team
matthewgallo
approved these changes
Jul 30, 2024
davidmenendez
approved these changes
Jul 30, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jul 30, 2024
95b7563
19 checks passed
AlexanderMelox
requested changes
Jul 30, 2024
| * Empty state link object | ||
| */ | ||
| link?: { | ||
| text?: string | ReactNode; |
There was a problem hiding this comment.
Suggested change
| text?: string | ReactNode; | |
| text?: ReactNode; |
ReactNode includes string no need to specify again
| /** | ||
| * Empty state subtitle | ||
| */ | ||
| subtitle?: string | ReactNode; |
There was a problem hiding this comment.
Suggested change
| subtitle?: string | ReactNode; | |
| subtitle?: ReactNode; |
| /** | ||
| * Empty state title | ||
| */ | ||
| title: string | ReactNode; |
There was a problem hiding this comment.
Suggested change
| title: string | ReactNode; | |
| title: ReactNode; |
| @@ -68,7 +68,7 @@ interface EmptyStateV2Props { | |||
| * Props for the link. Refer to the Carbon Components link documentation for full list of props. | |||
| */ | |||
| link?: { | |||
| text?: string; | |||
| text?: string | ReactNode; | |||
There was a problem hiding this comment.
Suggested change
| text?: string | ReactNode; | |
| text?: ReactNode; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4262
Convert
EmptyStateto typescriptWe need to add the
ReactNodetype to thelinkprop inEmptyStateV2as the same props fromEmptyStateare passed intoEmptyStateV2and typescript complains that the prop types do not matchWhat did you change?
packages/ibm-products/src/components/EmptyStates/EmptyState.tsxpackages/ibm-products/src/components/EmptyStates/EmptyStateV2.tsxHow did you test and verify your work?
storybook