Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(useInlineEdit): add typescript types #5529

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

anamikaanu96
Copy link
Contributor

Closes #5192

Converted packages/ibm-products/src/components/Datagrid/useInlineEdit.js to packages/ibm-products/src/components/Datagrid/useInlineEdit.tsx

What did you change? packages/ibm-products/src/components/Datagrid/useInlineEdit.tsx

How did you test and verify your work? storybook

@anamikaanu96 anamikaanu96 requested a review from a team as a code owner June 18, 2024 06:28
@anamikaanu96 anamikaanu96 requested review from davidmenendez and IgnacioBecerra and removed request for a team June 18, 2024 06:28
@anamikaanu96 anamikaanu96 enabled auto-merge June 18, 2024 06:29
Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 493e879
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66714befaf07d10008f84794
😎 Deploy Preview https://deploy-preview-5529--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devadula-nandan devadula-nandan self-requested a review June 18, 2024 08:12
Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@anamikaanu96 anamikaanu96 added this pull request to the merge queue Jun 18, 2024
Merged via the queue into carbon-design-system:main with commit 0bc2c3d Jun 18, 2024
16 of 17 checks passed
@anamikaanu96 anamikaanu96 deleted the useInlineEdit branch June 18, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Typescript types to useInlineEdit
3 participants