Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(useDatagrid): implement typescript types #5439

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

makafsal
Copy link
Member

Closes #5176

What did you change?

Changed packages/ibm-products/src/components/Datagrid/useDatagrid.js to packages/ibm-products/src/components/Datagrid/useDatagrid.ts

How did you test and verify your work?

Storybook
yarn test

@makafsal makafsal requested a review from a team as a code owner June 10, 2024 07:37
@makafsal makafsal requested review from davidmenendez and amal-k-joy and removed request for a team June 10, 2024 07:37
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit fe3a48f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6666b8b8e651c1000847db43
😎 Deploy Preview https://deploy-preview-5439--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@makafsal makafsal added this pull request to the merge queue Jun 11, 2024
Merged via the queue into carbon-design-system:main with commit 70a353c Jun 11, 2024
17 checks passed
@makafsal makafsal deleted the ts-useDatagrid-5176 branch June 11, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Typescript types to useDatagrid
3 participants