refactor(DataSpreadsheet): implement typescript types #5230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makafsal
requested review from
davidmenendez and
matthewgallo
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…products into typescript-dataspreadsheet
davidmenendez
requested changes
May 15, 2024
packages/ibm-products/src/components/DataSpreadsheet/DataSpreadsheet.tsx
Show resolved
Hide resolved
matthewgallo
requested changes
May 15, 2024
There was a problem hiding this comment.
Great job on this! This is a huge component with a lot of functionality. Can you break out the types for ActiveCellCoordinates, Column and possibly even PrevState into a separate type utility and use them across the DataSpreadsheet, DataSpreadsheetBody, and DataSpreadsheetHeader to reduce duplication?
matthewgallo
approved these changes
May 16, 2024
davidmenendez
approved these changes
May 16, 2024
Merged
via the queue into
carbon-design-system:main
with commit May 16, 2024
01baec0
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5118 #5119 #5120
What did you change?
packages/ibm-products/src/components/DataSpreadsheet/DataSpreadsheet.tsxpackages/ibm-products/src/components/DataSpreadsheet/DataSpreadsheetHeader.tsxpackages/ibm-products/src/components/DataSpreadsheet/DataSpreadsheetBody.tsxHow did you test and verify your work?
storybook