-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(createInfluencer): Add Typescript types #5129
Merged
sangeethababu9223
merged 6 commits into
carbon-design-system:main
from
sangeethababu9223:refactor/create-influencer-ts-types
May 20, 2024
Merged
refactor(createInfluencer): Add Typescript types #5129
sangeethababu9223
merged 6 commits into
carbon-design-system:main
from
sangeethababu9223:refactor/create-influencer-ts-types
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sangeethababu9223
requested review from
davidmenendez and
emyarod
and removed request for
a team
May 9, 2024 06:47
emyarod
reviewed
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like there is a type mismatch which is causing CI to fail
Thanks @emyarod. |
davidmenendez
approved these changes
May 14, 2024
devadula-nandan
approved these changes
May 20, 2024
Merged
via the queue into
carbon-design-system:main
with commit May 20, 2024
c93cf1f
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4517
Add Typescript types to CreateInfluencer
What did you change?
Changed the
CreateInfluencer.js
toCreateInfluencer.tsx
with typescript type supportHow did you test and verify your work?
Storybook