Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(InterstitialScreenViewModule): add typescript types #4975

Conversation

anamikaanu96
Copy link
Contributor

Contributes to #4484

Converted packages/ibm-products/src/components/InterstitialScreenViewModule/InterstitialScreenViewModule.js to packages/ibm-products/src/components/InterstitialScreenViewModule/InterstitialScreenViewModule.tsx

What did you change? packages/ibm-products/src/components/InterstitialScreenViewModule/InterstitialScreenViewModule.tsx

How did you test and verify your work? Storybook

@anamikaanu96 anamikaanu96 requested a review from a team as a code owner April 24, 2024 07:21
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 3547e87
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/662f7946fc2a650009387153
😎 Deploy Preview https://deploy-preview-4975--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anamikaanu96 anamikaanu96 linked an issue Apr 24, 2024 that may be closed by this pull request
Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment regarding use of PropsWithChildren (not required for this component).

@matthewgallo matthewgallo added this pull request to the merge queue Apr 29, 2024
Merged via the queue into carbon-design-system:main with commit 78cb388 Apr 29, 2024
16 checks passed
@anamikaanu96 anamikaanu96 deleted the InterstitialScreenViewModule branch May 6, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Typescript types to InterstitialScreenViewModule
2 participants