Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(CreateFullPage): add typescript types #4922

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

makafsal
Copy link
Member

Contributes to #4513

Typescript implementation

What did you change?

Changed the CreateFullPage.js to CreateFullPage.tsx with typescript type support

How did you test and verify your work?

Storybook

@makafsal makafsal requested a review from a team as a code owner April 17, 2024 07:17
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit beac9e3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6628a881eee5020008a0e5e9
😎 Deploy Preview https://deploy-preview-4922--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@makafsal makafsal requested a review from amal-k-joy April 22, 2024 04:58
@makafsal makafsal enabled auto-merge April 24, 2024 06:37
@makafsal makafsal added this pull request to the merge queue Apr 24, 2024
Merged via the queue into carbon-design-system:main with commit bee7576 Apr 24, 2024
16 checks passed
@makafsal makafsal deleted the createfullpage-ts-4513 branch April 24, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants