refactor(UserProfileImage): added TS types to the component #4773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for carbon-for-ibm-products failed.
|
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| /** | ||
| * When passing the image prop use the imageDescription prop to describe the image for screen reader. | ||
| */ | ||
| imageDescription: string; |
There was a problem hiding this comment.
This will need to be conditionally required only if image is provided
| /** | ||
| * Specify how the trigger should align with the tooltip | ||
| */ | ||
| tooltipAlignment?: |
There was a problem hiding this comment.
I think you could do something like this
tooltipAlignment?: React.ComponentProps<typeof IconButton>['align'];
matthewgallo
approved these changes
Apr 29, 2024
Merged
via the queue into
carbon-design-system:main
with commit Apr 29, 2024
f24cbe9
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4501
converted the component to ts, and added types.
What did you change?
packages/ibm-products/src/components/UserProfileImage/UserProfileImage.js -> tsx
How did you test and verify your work?
storybook, local verifying the available types on component