Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SidePanel): replace incorrect prop in conditional prop types #4630

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix(SidePanel): replace incorrect prop in conditional prop types #4630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions packages/ibm-products/src/components/SidePanel/SidePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,22 +188,21 @@ type SidePanelSlideInProps =
*/
slideIn?: false;
/**
* Specify a CSS selector that matches the DOM element that should
* be focused when the side panel opens.
* This is the selector to the element that contains all of the page content that will shrink if the panel is a slide in.
* This prop is required when using the `slideIn` variant of the side panel.
*/
selectorPrimaryFocus?: string;
selectorPageContent?: string;
}
| {
/**
* Determines if this panel slides in
*/
slideIn: true;
/**
* Specify a CSS selector that matches the DOM element that should
* be focused when the side panel opens. Required when for slide in
* panels
* This is the selector to the element that contains all of the page content that will shrink if the panel is a slide in.
* This prop is required when using the `slideIn` variant of the side panel. Required for slideIn panels.
*/
selectorPrimaryFocus: string;
selectorPageContent: string;
};

type SidePanelProps = SidePanelBaseProps & SidePanelSlideInProps;
Expand Down
Loading