Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FilterPanel): added accordion and group #4620

Conversation

paul-balchin-ibm
Copy link
Contributor

@paul-balchin-ibm paul-balchin-ibm commented Mar 27, 2024

Contributes to #4477

Migrating FilterPanelAccordion, FilterPanelAccordionItem, and FilterPanelGroup from Products v1 / Patterns / FilterPanel.

v1 references (there are no individual stories for these components, here is the link to the default story):

What did you change?

This is a new v2 subcomponent to FilterPanel.

FilterPanelAccordion prop updates

Old prop New prop ↓ Change
accordionProps New object {} specific to Carbon's Accordion component props.
children children No change.
className className No change.
count count No change.
heading labelText Renamed.
title title No change.

FilterPanelAccordionItem prop updates

Old prop New prop ↓ Change
accordionItemProps New object {} specific to Carbon's AccordionItem component props.
children children No change.
className className No change.
count count No change.
heading labelText Renamed.
title title No change.
truncatedListProps New object {} specific to TruncatedList component props.
collapseLabel Removed. Use truncatedListProps{collapsedItemsLimit} instead.
expandLabel Removed. Use truncatedListProps{expandedItemsLimit} instead.
scrollGradientColor Scroll gradients are deprecated in Carbon 11.

FilterPanelGroup prop updates

Old prop New prop ↓ Change
children children No change.
className className No change.
count count No change.
heading labelText Renamed.
title title No change.
countLabel Removed.
titleClassName Removed.

How did you test and verify your work?

  • Storybook
  • Tests (one test is failing, looking into it)

@paul-balchin-ibm paul-balchin-ibm requested a review from a team as a code owner March 27, 2024 13:42
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit aa105b9
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6606e506114633000986dcf4
😎 Deploy Preview https://deploy-preview-4620--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@paul-balchin-ibm paul-balchin-ibm self-assigned this Mar 27, 2024
@paul-balchin-ibm paul-balchin-ibm linked an issue Mar 27, 2024 that may be closed by this pull request
4 tasks
@paul-balchin-ibm paul-balchin-ibm added package: security version: 2 Carbon 11 / v2 area: migration ➡️ Migration of Security package to IBM Products labels Mar 27, 2024
Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, just noticed that all the canary labels are missing in Storybook now. 😬 Will re-approve once addressed.

Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m just gonna leave this here for you @paul-balchin-ibm. Turns out, nothing was actually wrong. The canary tags were just hidden because FilterPanelCheckboxWithOverflow name was so long. 🙈

image

@elycheea elycheea added this pull request to the merge queue Mar 29, 2024
Merged via the queue into carbon-design-system:main with commit ade8310 Mar 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: migration ➡️ Migration of Security package to IBM Products package: security version: 2 Carbon 11 / v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Component: FilterPanel
3 participants