-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FilterPanel): added accordion and group #4620
feat(FilterPanel): added accordion and group #4620
Conversation
…r-panel-checkbox-overflow-2
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/ibm-products-styles/src/components/FilterPanel/_filter-panel-accordion-item.scss
Outdated
Show resolved
Hide resolved
...ges/ibm-products-styles/src/components/FilterPanel/_filter-panel-checkbox-with-overflow.scss
Outdated
Show resolved
Hide resolved
packages/ibm-products-styles/src/components/FilterPanel/_filter-panel-checkbox.scss
Show resolved
Hide resolved
...es/ibm-products/src/components/FilterPanel/FilterPanelAccordion/FilterPanelAccordion.test.js
Outdated
Show resolved
Hide resolved
...roducts/src/components/FilterPanel/FilterPanelAccordionItem/FilterPanelAccordionItem.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, just noticed that all the canary labels are missing in Storybook now. 😬 Will re-approve once addressed.
Not sure why yet, but canary flags were not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m just gonna leave this here for you @paul-balchin-ibm. Turns out, nothing was actually wrong. The canary tags were just hidden because FilterPanelCheckboxWithOverflow name was so long. 🙈
ade8310
Contributes to #4477
Migrating FilterPanelAccordion, FilterPanelAccordionItem, and FilterPanelGroup from
Products v1 / Patterns / FilterPanel
.v1
references (there are no individual stories for these components, here is the link to the default story):What did you change?
This is a new
v2
subcomponent toFilterPanel
.FilterPanelAccordion prop updates
{}
specific to Carbon'sAccordion
component props.FilterPanelAccordionItem prop updates
{}
specific to Carbon'sAccordionItem
component props.{}
specific toTruncatedList
component props.collapseLabeltruncatedListProps{collapsedItemsLimit}
instead.expandLabeltruncatedListProps{expandedItemsLimit}
instead.scrollGradientColorFilterPanelGroup prop updates
countLabeltitleClassNameHow did you test and verify your work?